Unify the handling of error messages #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define a new function (displayError) that deals with undefined messages,
formatting the error stack, etc.
- Replace all .catch(function(error)) calls with a call to displayError so that
we can:
- have a unified format that we can modify in one location
- display meaningful error messages that should make it easier to figure out
what is wrong.
This makes the error message from e-mission/e-mission-docs#378
more meaningful
- Define a new function (displayError) that deals with undefined messages,
formatting the error stack, etc.
- Replace all .catch(function(error)) calls with a call to displayError so that
we can:
- have a unified format that we can modify in one location
- display meaningful error messages that should make it easier to figure out
what is wrong.
This makes the error message from e-mission/e-mission-docs#378
more meaningful
Bonus fix: fix the formatting in e-mission@94ffa9f I am not sure how this ever worked!
…ssion-phone into fix_error_displays
|
shankari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatting the error stack, etc.
we can:
what is wrong.
This makes the error message from e-mission/e-mission-docs#378
more meaningful